Skip to content

feat(BRE2-1054): uptake ssh certs for registered node - #458

Merged
patelspratik merged 1 commit into
mainfrom
feat/ssh-cert-node
Aug 27, 2026
Merged

feat(BRE2-1054): uptake ssh certs for registered node#458
patelspratik merged 1 commit into
mainfrom
feat/ssh-cert-node

Conversation

@patelspratik

@patelspratik patelspratik commented Aug 25, 2026

Copy link
Copy Markdown
Contributor
  • uptake SSH into External Node via SSH Certs
  • this presumes the external node has already been enabled and has the CA
    • the work to write the CA will be done in a separate PR

@patelspratik patelspratik changed the title Feat/ssh cert node feat(BRE2-1054): uptake ssh certs for registered node Aug 25, 2026
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.05556% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.10%. Comparing base (17ccd79) to head (013a210).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/mintcert/mintcert.go 56.52% 20 Missing ⚠️
pkg/ssh/sshconfigurer.go 87.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   24.67%   27.10%   +2.42%     
==========================================
  Files         134      138       +4     
  Lines       18337    19213     +876     
==========================================
+ Hits         4525     5208     +683     
- Misses      13335    13469     +134     
- Partials      477      536      +59     
Flag Coverage Δ
Linux 27.10% <68.05%> (+2.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@patelspratik
patelspratik marked this pull request as ready for review August 26, 2026 17:05
@patelspratik
patelspratik requested a review from a team as a code owner August 26, 2026 17:05
Comment thread pkg/store/user.go

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was causing the feature flag to not work correctly

@patelspratik
patelspratik merged commit 07e13ec into main Aug 27, 2026
9 checks passed
@patelspratik
patelspratik deleted the feat/ssh-cert-node branch August 27, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants