feat(BRE2-1051): ssh certs uptake - #452
Open
patelspratik wants to merge 1 commit into
Open
Conversation
patelspratik
force-pushed
the
feat/ssh-certs
branch
from
August 20, 2026 23:58
3d5b905 to
e719698
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
==========================================
+ Coverage 24.67% 26.20% +1.52%
==========================================
Files 134 137 +3
Lines 18337 18858 +521
==========================================
+ Hits 4525 4942 +417
- Misses 13335 13400 +65
- Partials 477 516 +39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
patelspratik
force-pushed
the
feat/ssh-certs
branch
4 times, most recently
from
August 24, 2026 19:21
f1c4114 to
9b4209d
Compare
Foundation for certificate-based SSH auth. Generates fresh ed25519
keypairs per renewal, caches the (private key, certificate) pair on
disk for the certificate's validity window, and writes atomically
(0600 private key). Files live under ~/.brev/ssh-certs/<envID>{,-cert.pub}
so a single IdentityFile directive loads both key and cert (OpenSSH
-cert.pub convention).
Independent of the IssueEnvironmentSSHCertificate RPC so the rest of
the feature can build and test before the generated connect client is
published. Includes EnvironmentCertEligible() mirroring dev-plane's
label constants (sshprovider=certauth).
patelspratik
force-pushed
the
feat/ssh-certs
branch
from
August 24, 2026 19:22
9b4209d to
80057f4
Compare
patelspratik
marked this pull request as ready for review
August 24, 2026 19:26
drewmalin
reviewed
Aug 24, 2026
| }) | ||
| }, | ||
| } | ||
| cmd.Flags().StringVar(&env, "env", "", "environment ID to mint a certificate for") |
Contributor
There was a problem hiding this comment.
Should we keep this vague (similar to ssh, which is "the name or ID") so that we could possibly support external nodes with the same command?
drewmalin
reviewed
Aug 24, 2026
| } | ||
|
|
||
| func makeSSHConfigEntryV2(workspace entity.Workspace, privateKeyPath string, cloudflaredBinaryPath string) (string, error) { //nolint:funlen,gocyclo // ok | ||
| var isSSHCertRequired = analytics.IsSSHCertRequired |
Contributor
There was a problem hiding this comment.
Is this so that it can be mocked?
drewmalin
reviewed
Aug 24, 2026
| } | ||
|
|
||
| sshConfig, err := makeNewSSHConfig(toWindowsPath(configPath), workspaces, toWindowsPath(pkpath), toWindowsPath(cloudflaredBinaryPath)) | ||
| sshConfig, err := makeNewSSHConfig(toWindowsPath(configPath), workspaces, toWindowsPath(pkpath), toWindowsPath(cloudflaredBinaryPath), false) |
Contributor
There was a problem hiding this comment.
Could we pass a const or enum for this final boolean?
drewmalin
reviewed
Aug 24, 2026
| return now.Add(margin).Unix() < notAfter | ||
| } | ||
|
|
||
| func HasValidCertAt(fs afero.Fs, certPath string, now time.Time, margin time.Duration) (bool, error) { |
Contributor
There was a problem hiding this comment.
Should we similarly check that the private key is sound / paired to the public key that this cert was issued for ?
drewmalin
reviewed
Aug 24, 2026
| {{ end }} | ||
| ` | ||
|
|
||
| const SSHCertRequiredTemplateV2 = `Match host {{ .Alias }} exec {{ .ExecCommand }} |
Contributor
There was a problem hiding this comment.
Do the exec commands need to be quoted (and below)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.