Skip to content

fix: brev-open-command-triggers-two-concurrent-interactive-login-prompts #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hakhandelwal11 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

fix: brev-open-command-triggers-two-concurrent-interactive-login-prompts #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/cmd/open/open.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ type OpenStore interface {
GetWorkspace(workspaceID string) (*entity.Workspace, error)
GetWindowsDir() (string, error)
IsWorkspace() (bool, error)
GetAccessToken() (string, error)
}

func NewCmdOpen(t *terminal.Terminal, store OpenStore, noLoginStartStore OpenStore) *cobra.Command {
Expand Down Expand Up @@ -280,6 +281,9 @@ func handleSetDefault(t *terminal.Terminal, editorType string) error {

// Fetch workspace info, then open code editor
func runOpenCommand(t *terminal.Terminal, tstore OpenStore, wsIDOrName string, setupDoneString string, directory string, host bool, editorType string) error { //nolint:funlen,gocyclo // define brev command
if _, err := tstore.GetAccessToken(); err != nil {
return breverrors.WrapAndTrace(err)
}
// todo check if workspace is stopped and start if it if it is stopped
fmt.Println("finding your instance...")
res := refresh.RunRefreshAsync(tstore)
Expand Down
Loading