Expose API URL security env vars#87
Draft
Olmo Maldonado (ibolmo) wants to merge 1 commit into
Draft
Conversation
Olmo Maldonado (ibolmo)
changed the title
| {{- end -}} | ||
| {{- $urlSecurityDnsServers := .Values.api.urlSecurityDnsServers | default "" | toString | trim -}} | ||
| {{- $urlSecurityAllowCidrs := .Values.api.urlSecurityAllowCidrs | default "" | toString | trim -}} | ||
| --- |
Contributor
There was a problem hiding this comment.
Remove these from the top so they are not hoisted and have them inline with the values to match how we have other values in the config map. We also aren't using fail today for validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Braintrust backends now support URL-security controls for outbound requests to user-supplied URLs. The Helm chart needs first-class knobs for self-hosted API deployments to configure those controls without relying on
api.extraEnvVars.Description
BRAINTRUST_*env vars into the API ConfigMap only when the trimmed values are non-empty, preserving application defaults when unset.api.unsafeUrlRequestModeduring template rendering so only empty,off,warn, orrejectare accepted.