feat(scorers): create LLM scorers and classifiers - #307
Merged
Conversation
Contributor
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/scorers-create
branch
from
August 14, 2026 20:15
5e13709 to
8f1e4c0
Compare
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/scorers-create
branch
from
August 14, 2026 20:32
8f1e4c0 to
9d92d66
Compare
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/scorers-create
branch
from
August 14, 2026 21:15
9d92d66 to
06883fe
Compare
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/scorers-create
branch
from
August 14, 2026 21:27
06883fe to
ddc82b0
Compare
Cedric / ViaDézo1er (viadezo1er)
changed the base branch from
cedric/fix-btql-safety
to
main
August 14, 2026 21:31
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/scorers-create
branch
from
August 14, 2026 22:49
0d53e92 to
9963a33
Compare
Cedric / ViaDézo1er (viadezo1er)
marked this pull request as ready for review
August 14, 2026 22:50
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9963a33d87
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Cedric / ViaDézo1er (viadezo1er)
requested review from
Stephen Belanger (Qard) and
Parker Henderson (parkerhendo)
August 14, 2026 23:12
Stephen Belanger (Qard)
approved these changes
Aug 14, 2026
Stephen Belanger (Qard)
approved these changes
Aug 18, 2026
Stephen Belanger (Qard)
left a comment
Contributor
There was a problem hiding this comment.
Still overall LGTM, though CI still seems to be failing, and looks like it needs a rebase.
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/scorers-create
branch
2 times, most recently
from
August 18, 2026 20:57
a8f8b84 to
e737d2b
Compare
Contributor
Author
|
Rebase done |
…has been ignored when it happens
…se instead of what bt asked to be created
…_api_key responses are classified as user/provider errors, not Braintrust authentication failures
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/scorers-create
branch
from
August 19, 2026 00:40
c8cf632 to
7fed713
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
bt scorers createfor prompt-based LLM scorers and classifiers.Parameter validation is a follow-up partly done in #308, and partly done in https://github.com/braintrustdata/braintrust/pull/18155 (and
btwill need tweaking once the braintrust pr is merged).At the moment it is possible to pass incorrect parameters to the scorers, and sometimes the web ui will even show them:
bt-scorer-messages.json:[ { "role": "system", "content": "You are a strict evaluator. Compare the candidate answer with the expected answer. Return exactly PASS or FAIL." }, { "role": "user", "content": "Question: {{input.question}}\nExpected answer: {{expected}}\nCandidate answer: {{output}}" } ]