Delegate trace commands to plugin runtime - #299
Merged
Conversation
Stephen Belanger (Qard)
force-pushed
the
agent/refresh-codex-trace-plugin
branch
from
August 12, 2026 20:14
c4b2175 to
deaeb8e
Compare
Contributor
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
Stephen Belanger (Qard)
force-pushed
the
agent/refresh-codex-trace-plugin
branch
from
August 12, 2026 20:31
deaeb8e to
9f9ed79
Compare
Stephen Belanger (Qard)
marked this pull request as ready for review
August 12, 2026 20:47
Abhijeet Prasad (AbhiPrasad)
approved these changes
Aug 12, 2026
Stephen Belanger (Qard)
force-pushed
the
agent/refresh-codex-trace-plugin
branch
from
August 12, 2026 21:06
9f9ed79 to
bf03da0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
braintrust-coding-agent-plugins#20bt_daemon::TraceArgstree under the top-levelbt tracenamespacesrc/agents.rsand delegate the complete trace command tobt_daemon::run_traceOwnership boundary
btno longer matches or interprets any coding-agent trace subcommand. It hands the parsed trace command to the plugin runtime with the current executable mount prefix and an implementation of the host-service interface.The plugin repository owns setup, daemon lifecycle, hooks, status, stop, imports, managed runs, output rendering, agent package identities, marketplace behavior, and settings reconciliation.
btcontinues to own its profile store, OAuth/API-key handling, project picker, and top-level Clap mount.This PR depends on
braintrustdata/braintrust-coding-agent-plugins#20and pins its exact commit.Validation
cargo fmt --all --checkcargo check --lockedcargo test --locked --test cli trace_(13 passed)cargo test --locked --quiet -- --test-threads=1(803 passed)cargo clippy --locked --all-targets --all-features -- -D warnings -A clippy::collapsible_matchgit diff --checkStrict Clippy without the targeted allowance remains blocked by 12 existing
collapsible_matchfindings in unrelated files.