feat: Add support for @aws-sdk/client-bedrock-runtime#2145
Open
Luca Forstner (lforst) wants to merge 5 commits into
Open
feat: Add support for @aws-sdk/client-bedrock-runtime#2145Luca Forstner (lforst) wants to merge 5 commits into
@aws-sdk/client-bedrock-runtime#2145Luca Forstner (lforst) wants to merge 5 commits into
Conversation
|
|
||
| const output: Record<string, unknown> = {}; | ||
| for (const [key, nested] of Object.entries(value)) { | ||
| output[key] = sanitizeBedrockValue(nested, depth + 1); |
There was a problem hiding this comment.
prototype pollution? I guess the values from a bedrock response is safer, but we should still be careful just copying every value here.
Comment on lines
+211
to
+212
| "cacheReadInputTokenCount": 0, | ||
| "cacheWriteInputTokenCount": 0, |
There was a problem hiding this comment.
should these cache tokens become braintrust metrics?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1741