Open
Conversation
Andrew Kent (realark)
force-pushed
the
ark/bedrock-instrumentation
branch
2 times, most recently
from
bab8b95 to
bfbc715
Compare
Andrew Kent (realark)
force-pushed
the
ark/bedrock-instrumentation
branch
4 times, most recently
from
a812af8 to
f346098
Compare
Andrew Kent (realark)
force-pushed
the
ark/bedrock-instrumentation
branch
4 times, most recently
from
472bba1 to
8e03cc3
Compare
Andrew Kent (realark)
force-pushed
the
ark/bedrock-instrumentation
branch
from
8e03cc3 to
afc157d
Compare
Abhijeet Prasad (AbhiPrasad)
approved these changes
Apr 20, 2026
| log.debug("Failed to capture response body", e); | ||
| } | ||
| } | ||
| return body; |
There was a problem hiding this comment.
on error, this will return a half consumed input stream right? So I guess that makes it unsafe. Should we just propagate the exception then?
| } | ||
|
|
||
| @Override | ||
| public void beforeExecution( |
There was a problem hiding this comment.
should we gate by operationName so we don't run this on every single span?
| testRuntimeOnly "org.slf4j:slf4j-simple:${slf4jVersion}" | ||
| testImplementation "software.amazon.awssdk:bedrockruntime:${awsBedrockVersion}" | ||
| testImplementation "software.amazon.awssdk:netty-nio-client:${awsBedrockVersion}" | ||
| testImplementation 'com.fasterxml.jackson.core:jackson-databind:2.17.0' |
There was a problem hiding this comment.
do we want to hardcode jackson-databind version?
| * Rewrites the Host header to the real AWS hostname so SigV4 signing is valid even when the | ||
| * request is sent to the local WireMock proxy via endpointOverride. | ||
| */ | ||
| private static class HostRewriteInterceptor implements ExecutionInterceptor { |
There was a problem hiding this comment.
this is duplicated with btx/src/test/java/dev/braintrust/sdkspecimpl/SpecExecutor.java. Should we DRY?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bedrock instrumentation
instrumentation also tested against new llm span spec tests: braintrustdata/braintrust-spec#12