fix_bot_issue: tolerate model_specs emitted as an array - #1131
Open
Erin McNulty (erin2722) wants to merge 1 commit into
Open
fix_bot_issue: tolerate model_specs emitted as an array#1131Erin McNulty (erin2722) wants to merge 1 commit into
Erin McNulty (erin2722) wants to merge 1 commit into
Conversation
The gap-audit agent is instructed to emit `model_specs` as a record keyed
by model id, but it sometimes deviates and emits an array of
`{ id, ...spec }` objects (e.g. issue #1117). The strict
`z.record(partialModelSchema)` rejected that, so `parseIssueMetadata`
discarded ALL metadata and the resolver bailed with "did not contain
parseable bot metadata", labeling the issue `autofix-blocked`.
Add a `normalizeModelSpecs` preprocess that converts the array form back
into the documented record (keyed by each item's `id`, stripping `id`),
leaving record inputs untouched. Record consumers
(`model_specs?.[targetModel]`) are unchanged.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gap-audit agent is instructed to emit
model_specsas a record keyed by model id, but it sometimes deviates and emits an array of{ id, ...spec }objects (e.g. issue #1117). The strictz.record(partialModelSchema)rejected that, soparseIssueMetadatadiscarded ALL metadata and the resolver bailed with "did not contain parseable bot metadata", labeling the issueautofix-blocked.Add a
normalizeModelSpecspreprocess that converts the array form back into the documented record (keyed by each item'sid, strippingid), leaving record inputs untouched. Record consumers(
model_specs?.[targetModel]) are unchanged.