fix: end the pipeline at the release PR instead of chaining a broken publish - #33
Merged
Merged
Conversation
adrmachado-public
approved these changes
Aug 19, 2026
There was a problem hiding this comment.
Pull request overview
Updates the reusable release-pipeline workflow so it stops after opening the release PR, instead of attempting to immediately publish from a tag that doesn’t exist yet.
Changes:
- Removes the chained
publishreusable-workflow call fromrelease-pipeline. - Removes the now-unused
new-versionjob output frombump-version.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
58
to
62
| bump-version: | ||
| needs: ci | ||
| runs-on: ${{ inputs.runs-on }} | ||
| permissions: | ||
| contents: write |
Comment on lines
61
to
66
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| outputs: | ||
| new-version: ${{ steps.bump.outputs.new-version }} | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-pipelinechained apublishjob that checked outv${new-version}right afterbump-version, but bump-version only opens a release PR and does not tag (release-pr.ts: tagging happens on merge). So the tag never existed at that point and publish always failed.Removes the chained
publishjob (and the now-unusednew-versionoutput). The pipeline now ends at opening the release PR. Publishing is a separate step against the tag once the PR merges. Thenpm-tokensecret stays declared so callers passing it don't break.