wip: don't mutate lines excluded from coverage - #547
Open
nedbat wants to merge 3 commits into
Open
Conversation
Written by Claude. I haven't reviewed it.
Author
|
This now does what I needed it to do. I had code like this: and I have a coverage setting to exclude With this pull request, those cases are not mutated, because the coverage analysis is used to understand that they are excluded. |
nedbat
marked this pull request as ready for review
August 7, 2026 15:38
nedbat
commented
Aug 8, 2026
| (m for m in mutated_methods if m.line_number_start <= error.line_number <= m.line_number_end), None | ||
| ) | ||
| if mutant is None: | ||
| continue |
Owner
|
I looked through this a bit and it looks like a good improvement. The tests fail though, I guess that's because of the workaround for #541 ? |
Owner
|
Great. This is merge-ready now then? Seems like an improvement over the code on main at least. |
Author
|
I don't know of a reason not to merge it. I really haven't read the code I'm sorry to say. I understand if you'd want to hold off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude. I haven't reviewed it.