Skip to content

fix(content-sharing): remove enterprise name in shared link access#4514

Merged
mergify[bot] merged 3 commits intobox:masterfrom
tjuanitas:fix-content-sharing-remove-enterprise
Apr 23, 2026
Merged

fix(content-sharing): remove enterprise name in shared link access#4514
mergify[bot] merged 3 commits intobox:masterfrom
tjuanitas:fix-content-sharing-remove-enterprise

Conversation

@tjuanitas
Copy link
Copy Markdown
Contributor

@tjuanitas tjuanitas commented Apr 22, 2026

Before
Screenshot 2026-04-22 at 3 57 27 PM

After
Screenshot 2026-04-22 at 3 56 32 PM

Summary by CodeRabbit

Release Notes

  • Refactor
    • Simplified user data structure in content sharing by removing enterprise information from the current user context, streamlining the data passed to the sharing modal.

@tjuanitas tjuanitas requested review from a team as code owners April 22, 2026 23:02
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e0bdeac8-dc35-47bc-a4fc-72e7fd097798

📥 Commits

Reviewing files that changed from the base of the PR and between 1a97587 and 4ff41d5.

📒 Files selected for processing (1)
  • src/elements/content-sharing/utils/__mocks__/ContentSharingV2Mocks.js
💤 Files with no reviewable changes (1)
  • src/elements/content-sharing/utils/mocks/ContentSharingV2Mocks.js

Walkthrough

The ContentSharingV2 user initialization now sets currentUser to only include the user id; enterprise data was removed from the component state. hostname is still read to build serverUrl, but enterprise info is no longer forwarded to the Unified Share Modal. (≤50 words)

Changes

Cohort / File(s) Summary
Current User State Simplification
src/elements/content-sharing/ContentSharingV2.tsx
Removed enterprise population from currentUser state; currentUser now contains only id. hostname still used to derive serverUrl.
Mocks Updated to Match Payload Shape
src/elements/content-sharing/utils/__mocks__/ContentSharingV2Mocks.js
Removed enterprise: { name: ... } from DEFAULT_USER_API_RESPONSE, aligning mock API payload with the new currentUser shape.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐇 I hopped through code with nimble paws,

nibbled fields and trimmed the claws.
Now only IDs hop in the cart—
lighter state, a lighter heart.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing enterprise name from the shared link access UI, which aligns with the code changes reducing currentUser state to only include user ID and removing enterprise field.
Description check ✅ Passed The PR description provides visual before/after screenshots clearly demonstrating the UI changes from 'People in Trevor's Enterprise' to 'People in your company', effectively communicating the intent despite missing structured sections from the template.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 23, 2026

Merge Queue Status

  • Entered queue2026-04-23 04:16 UTC · Rule: Automatic strict merge
  • Checks passed · in-place
  • Merged2026-04-23 04:26 UTC · at 724b1affb21bcf906b89fa4e7319d0b2835fed86 · squash

This pull request spent 9 minutes 5 seconds in the queue, including 8 minutes 54 seconds running CI.

Required conditions to merge

@mergify mergify Bot merged commit 90261fc into box:master Apr 23, 2026
8 of 9 checks passed
@mergify mergify Bot removed the queued label Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants