Use Field3DParallel if we need parallel fields - #3453
Open
dschwoerer wants to merge 2 commits into
Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| Field3D Div_par(const Field3D& f, const Field3D& v) { | ||
| Field3D Div_par(const Field3DParallel& f, const Field3DParallel& v) { |
Contributor
There was a problem hiding this comment.
warning: function 'Div_par' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]
Suggested change
| Field3D Div_par(const Field3DParallel& f, const Field3DParallel& v) { | |
| static Field3D Div_par(const Field3DParallel& f, const Field3DParallel& v) { |
Contributor
Author
There was a problem hiding this comment.
I fail to see why this function is hidden, but if it really is not exposed, we should probably delete it instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #3430 this makes Div_par just work in many cases for FCI.