Add Conduction_Methods to Div_par_K_Grad_par_mod - #3452
Open
dschwoerer wants to merge 4 commits into
Open
Conversation
Copied from Hermes-3 Co-authored-by: Ben Dudson <dudson2@llnl.gov>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| Field3D Div_par_K_Grad_par_mod(const Field3D& Kin, const Field3D& fin, Field3D& flow_ylow, | ||
| bool bndry_flux) { | ||
| namespace bout { | ||
| enum ConductionMethod : uint8_t { Original, ProductJK, Harmonic }; |
Contributor
There was a problem hiding this comment.
warning: enum 'ConductionMethod' is unscoped, use 'enum class' instead [cppcoreguidelines-use-enum-class]
enum ConductionMethod : uint8_t { Original, ProductJK, Harmonic };
^
bendudson
reviewed
Aug 11, 2026
| } // namespace | ||
|
|
||
| Field3D Div_par_K_Grad_par_mod(const Field3D& Kin, const Field3D& fin, Field3D& flow_ylow, | ||
| bool bndry_flux, const std::string& method) { |
Contributor
There was a problem hiding this comment.
I think I would prefer an enum runtime argument here, rather than passing a string and having to match strings each time. Options can do the conversion of input strings to BOUT++ enums. Remembering to omit the i in "orginal" is one reason :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from Hermes-3: boutproject/hermes-3#578
This makes it a runtime choice, using a templated function. It has currently has no options based control mechanism, so it needs to be selected by the API user, requiring changes in Hermes-3.