Skip to content

fix(redis): preserve empty arrays in payload#15

Closed
rrmesquita wants to merge 1 commit into
boringnode:mainfrom
rrmesquita:main
Closed

fix(redis): preserve empty arrays in payload#15
rrmesquita wants to merge 1 commit into
boringnode:mainfrom
rrmesquita:main

Conversation

@rrmesquita
Copy link
Copy Markdown

@rrmesquita rrmesquita commented Jun 2, 2026

DISCLAIMER: Since I'm not too familiar with the codebase, this PR was AI assisted with Opus 4.8 high. Feel free to discard the PR — although I think the solution here makes sense.

@thetutlage thetutlage requested a review from RomainLanz June 3, 2026 08:09
@RomainLanz
Copy link
Copy Markdown
Member

Thanks for sending this, the bug is real and the direction makes sense.

I think we need to take the fix a bit further before merging. This patch protects the popFrom() and getJob() return paths, but Redis still has other scripts that decode the stored job JSON and then write it back.

I would rather make the invariant explicit. user job JSON/payload should stay opaque to Lua, and any Lua-side mutable metadata should be handled without re-encoding the full job.

I'm going to take this on from our side because it touches a few Redis internals, but this PR helped identify the right problem. Thanks again for digging into it.

@RomainLanz RomainLanz closed this Jun 3, 2026
RomainLanz added a commit that referenced this pull request Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants