Skip to content

Neural Network-based cable spline avoidance - #438

Merged
kshaji3 merged 30 commits into
masterfrom
nn_factor
Aug 25, 2026
Merged

Neural Network-based cable spline avoidance#438
kshaji3 merged 30 commits into
masterfrom
nn_factor

Conversation

@kshaji3

@kshaji3 kshaji3 commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Key additions:

  1. Adds in a method for using neural network based dynamics prediction into GT Dynamics.
  2. Adds a factor that allows you to have a neural network-based model of cable spline prediction (as a psuedospectral chebyshev polynomial) attached to the robot body as a collision constraint.
  3. Workshop paper was submitted on this framework.

@kshaji3
kshaji3 marked this pull request as ready for review August 18, 2026 22:33
@kshaji3
kshaji3 requested a review from dellaert August 18, 2026 22:33

@dellaert dellaert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes based on correctness, performance, API design, and GTSAM style/test-organization guidance. The relevant C++ tests and all six CI jobs pass, but the inline issues below should be addressed before merging.

Comment thread gtdynamics/gpmp2/ObstacleCost.cpp
Comment thread gtdynamics/dynamics/MLP.cpp
Comment thread gtdynamics/dynamics/MLP.cpp Outdated
Comment thread gtdynamics/gpmp2/NNCableSpline.cpp
Comment thread gtdynamics/dynamics/tests/testMLP.cpp Outdated
Comment thread gtdynamics/gpmp2/NNCableSpline.h Outdated
Comment thread gtdynamics/gpmp2/NNCableSpline.cpp Outdated
Comment thread gtdynamics/gpmp2/NNCableSpline.cpp Outdated
Comment thread gtdynamics/dynamics/MLP.cpp
@kshaji3

kshaji3 commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

Finally passed CI!

@kshaji3
kshaji3 merged commit ea33673 into master Aug 25, 2026
9 of 10 checks passed
@kshaji3
kshaji3 deleted the nn_factor branch August 25, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants