Fix leaks, optimize memory usage#157
Merged
ThomasWaldmann merged 3 commits intoborgbackup:masterfrom Apr 24, 2026
Merged
Conversation
ThomasWaldmann
force-pushed
the
fix-leaks
branch
from
82833a3 to
faa609e
Compare
- Store paramiko.SSHClient in self.ssh and ensure it is closed in _disconnect. - _connect calls _disconnect on any failure during setup.
Ensure the rclone process is properly terminated and waited on in close(), preventing zombie processes and resource leaks.
Use a generator expression to convert backend items to dictionaries directly for json.dumps(). This avoids building an intermediate list of ItemInfo objects, reducing memory pressure for large directories. This is only a slight optimization, avoiding to stream one dict after another manually, which would save more memory, but require uglier code. We operate at backend api layer, we only list single dirs.
ThomasWaldmann
force-pushed
the
fix-leaks
branch
from
faa609e to
8da7771
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.