REST server nginx systemd socket activation#156
Open
ThomasWaldmann wants to merge 2 commits intoborgbackup:masterfrom
Open
REST server nginx systemd socket activation#156ThomasWaldmann wants to merge 2 commits intoborgbackup:masterfrom
ThomasWaldmann wants to merge 2 commits intoborgbackup:masterfrom
Conversation
ThomasWaldmann
force-pushed
the
rest-server-nginx-systemd-socket-activation
branch
3 times, most recently
from
3250bf4 to
2880b8d
Compare
ThomasWaldmann
force-pushed
the
rest-server-nginx-systemd-socket-activation
branch
10 times, most recently
from
8a9d53e to
b936b9f
Compare
See discussion in PR borgbackup#155 and thanks to @f-froehlich for bringing this up! The backend code will work ok even with an empty path or without a trailing slash. Note: the REST server currently does not support sub-paths, but only serves one backend / store at the root path. There is now a contrib/server/nginx-systemd/ subdirectory with a reverse proxy setup example that can support multiple stores at different sub-paths.
Add --socket-activation flag: the server adopts a pre-bound socket from systemd (SD_LISTEN_FDS) instead of binding itself, enabling on-demand per-repo startup without port management. Add contrib/server/nginx-systemd/ with an example configuration for systemd / nginx / borgstore.server.rest using domain sockets. See the README there for details. We use these example configs in CI testing (see ci.yml) on github.
ThomasWaldmann
force-pushed
the
rest-server-nginx-systemd-socket-activation
branch
from
b936b9f to
11e3910
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.