_chunker.c: fix some bugs#9576
Open
ThomasWaldmann wants to merge 1 commit intoborgbackup:1.4-maintfrom
Open
Conversation
Member
ThomasWaldmann
commented
Apr 20, 2026
ThomasWaldmann
commented
- better check return value of fd.read(n) and reject if it returns more bytes than requested.
- avoid giving len<=0 to posix_fadvise(), which could drop the rest of the file from cache.
- chunker_fill: correctly Py_DECREF in case of an error in PyBytes_Size
- buzhash: check for len == 0 edge case
- better check return value of fd.read(n) and reject if it returns more bytes than requested. - avoid giving len<=0 to posix_fadvise(), which could drop the rest of the file from cache. - chunker_fill: correctly Py_DECREF in case of an error in PyBytes_Size - buzhash: check for len == 0 edge case
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.4-maint #9576 +/- ##
=============================================
- Coverage 81.97% 81.95% -0.02%
=============================================
Files 38 38
Lines 11299 11299
Branches 1778 1778
=============================================
- Hits 9262 9260 -2
- Misses 1452 1453 +1
- Partials 585 586 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.