bugfix : review assert and replace by if condition#8682
Draft
120EE0980 wants to merge 1 commit into
Draft
Conversation
Member
|
commenting to trigger re-indexing of this PR, so it gets visible again on the github web UI open PR list. |
ThomasWaldmann
force-pushed
the
replaceassert
branch
from
38d0ae2 to
922a7d4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8682 +/- ##
==========================================
- Coverage 84.78% 84.69% -0.09%
==========================================
Files 92 92
Lines 15251 15254 +3
Branches 2286 2289 +3
==========================================
- Hits 12930 12920 -10
- Misses 1621 1632 +11
- Partials 700 702 +2 ☔ View full report in Codecov by Harness. |
ThomasWaldmann
force-pushed
the
replaceassert
branch
3 times, most recently
from
8abef29 to
11ec56f
Compare
Member
|
Updated and force-pushed:
Quite some tests broken due to issues with our requirements, this is unrelated to this PR. |
Signed-off-by: Nish_ <120EE0980@nitrkl.ac.in>
ThomasWaldmann
force-pushed
the
replaceassert
branch
from
11ec56f to
e45959a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #8649
This PR only incorporates very small part of the solution to the issue.(i.e only replaces assert in 2 files)
This is just a draft to confirm whether right path is being followed.(will push other changes after I get an OK from reviewer)