cache sync: log per-archive messages at debug level, fixes #9659 - #10217
Merged
ThomasWaldmann merged 1 commit intoAug 27, 2026
Merged
Conversation
…#9659 The chunks cache sync emitted 2 INFO lines per archive: - warm chunks.archive.d (the usual case): "Reading cached archive chunk index for <name> ..." plus "Merging into master chunks index ..." - cache rebuild: "Fetching and building archive index for <name> ..." plus "Merging into master chunks index ..." On repositories with many archives this floods the output of anybody running with -v / --info, without telling them much - "Merging into master chunks index ..." does not even name the archive. Log these at debug level, so --info now only shows the summary: Synchronizing chunks cache... Archives: %d, w/ cached Idx: %d, w/ outdated Idx: %d, w/o cached Idx: %d. Done. Per-archive feedback for interactive use is still available via --progress (the cache.sync progress indicator names each archive), and borg 2 already logs all of this at debug level.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.4-maint #10217 +/- ##
=============================================
- Coverage 82.14% 82.10% -0.04%
=============================================
Files 38 38
Lines 11475 11475
Branches 1807 1807
=============================================
- Hits 9426 9422 -4
- Misses 1464 1466 +2
- Partials 585 587 +2 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9659.
The chunks cache sync emitted 2 INFO lines per archive, so
-v/--infofloods on repos with many archives:chunks.archive.d(the usual case):Reading cached archive chunk index for <name> ...+Merging into master chunks index ...Fetching and building archive index for <name> ...+Merging into master chunks index ...The issue listed three lines (872/875/879), but missed
cache.py:804(Reading cached archive chunk index), which is the partner of theMergingline in the common warm-cache path — without it, only half the noise would go away. This PR demotes all four.--infooutput is now just the summary the reporter asked for:Notes:
--progressstill drives thecache.syncProgressIndicatorPercent, which names each archive as it is processed.cache.py— so this aligns the branches.ArchiverCorruptionTestCase::test_chunks_archivegreps for two of these messages, so itscreate -vbecomescreate --debug. (Its third assert is alogger.errorand is unaffected.)