Conversation
When E2E_REGISTRY_AUTH=true, Env.New() creates a test-scoped dockerconfigjson Secret from E2E_REGISTRY_HOST, E2E_REGISTRY_USER, and E2E_REGISTRY_PASSWORD. NewPool() auto-injects it via WithPullSecret so individual tests don't need to handle auth. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com>
Restrict TestPullSecretAuth to bink only since pull secret injection is now handled by the framework. Enable TestUpdateReboot on EKS as the first test to target. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com>
Add E2E_REGISTRY_AUTH, E2E_REGISTRY_HOST to the e2e-eks target so the framework creates node pull secrets automatically. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com>
Collaborator
Author
|
Before switching to this change, the target test requires a rollback that is pullable and it isn't the case for EKS yet. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain cluster provider might require a pull secret for pulling the node images.