Skip to content

Wrong fallback logic for name() libbacktrace backend #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prbegd wants to merge 5 commits into
base: develop
Choose a base branch
from
+7 −1
Open

Wrong fallback logic for name() libbacktrace backend #224

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89023f7
Fix for issue 212
prbegd Jan 24, 2026
f39e222
Fix libbacktrace_full_callback return value
prbegd Jan 25, 2026
73347cb
Fix: libbacktrace_full_callback will return 0 if there is no data
prbegd Jan 25, 2026
44b87d6
Merge branch 'boostorg:develop' into develop
prbegd Jul 10, 2026
32b23c0
Revert "Fix for issue 212"
prbegd Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion include/boost/stacktrace/detail/libbacktrace_impls.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,20 @@ inline void libbacktrace_syminfo_callback(void *data, uintptr_t pc, const char *

inline int libbacktrace_full_callback(void *data, uintptr_t /*pc*/, const char *filename, int lineno, const char *function) {
pc_data& d = *static_cast<pc_data*>(data);
int return_value = 0;
if (d.filename && filename) {
*d.filename = filename;
return_value = 1;
}
if (d.function && function) {
*d.function = function;
return_value = 1;
}
d.line = static_cast<std::size_t>(lineno);
return 0;
if (d.line) {
return_value = 1;
}
return return_value;
}

inline void libbacktrace_error_callback(void* /*data*/, const char* /*msg*/, int /*errnum*/) noexcept {
Expand Down