Move t instead of copying the value#330
Closed
venkat-murty wants to merge 1 commit into
Closed
Conversation
gennaroprota
added a commit
that referenced
this pull request
Jul 20, 2026
`load_impl` read the value into a local and copy-assigned it to the optional. A move-only value type then failed to compile: `optional`'s perfect-forwarding assignment is removed by SFINAE when the value is not copy-assignable, leaving no viable `operator=`. So, move the local into the optional instead. The one-line fix was proposed by Venkat Murty in PR #330; this extends it with `boost::move` and a regression test.
Collaborator
|
Thanks. Modified a bit into PR #348, with a regression test. |
gennaroprota
added a commit
that referenced
this pull request
Jul 20, 2026
`load_impl` read the value into a local and copy-assigned it to the optional. A move-only type then failed to compile: `optional`'s perfect-forwarding assignment is removed by SFINAE when the value is not copy-assignable, leaving no viable `operator=`. So, move the local into the optional instead. The one-line fix was proposed by Venkat Murty in PR #330; this extends it with `boost::move` and a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::optional<T>does not compile when T has a move operator and the copy operator is deleted.