fix dropped storage in single-element value(initializer_list) - #1184
Open
Ramya-9353 wants to merge 1 commit into
Open
fix dropped storage in single-element value(initializer_list)#1184Ramya-9353 wants to merge 1 commit into
Ramya-9353 wants to merge 1 commit into
Conversation
|
An automated preview of the documentation is available at https://1184.json.prtest2.cppalliance.org/libs/json/doc/html/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-08-08 11:23:53 UTC |
|
GCOVR code coverage report https://1184.json.prtest2.cppalliance.org/gcovr/index.html Build time: 2026-08-08 11:39:58 UTC |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: value jv({{1, 2, 3}}, sp) reports jv.storage() as the default resource rather than sp; the two-or-more element and object list forms adopt sp correctly.
Cause: the size()==1 branch of value(initializer_list<value_ref>, storage_ptr) constructs *this on the default resource with scalar(), builds the element on sp, then swaps; swap keeps each operand's own storage, so sp is discarded.
Fix: construct *this directly from the element's value, which already holds sp.