refactor: remove dependency on boost.tti using detector idiom#531
Open
Becheler wants to merge 1 commit into
Open
refactor: remove dependency on boost.tti using detector idiom#531Becheler wants to merge 1 commit into
Becheler wants to merge 1 commit into
Conversation
|
Compiler-warning counts vs
|
|
Boost dependency footprint vs Header-inclusion weights (graph files pulling each direct dependency in):
Transitive Boost modules: 69 → 68 (-1)
|
Becheler
marked this pull request as ready for review
July 17, 2026 11:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dependency to Boost.TTI. Use void_t detector idiom instead.
Before submitting
developbranch.Type of change
Does this PR introduce a breaking change?
What this PR does
Removes Boost.Graph's dependency on Boost.TTI (and the last MPL use in DFS).
depth_first_search.hpp: replaced theBOOST_TTI_HAS_MEMBER_FUNCTION(finish_edge)detector and its__GNUC__/clang/intel#iffork with avoid_texpression-SFINAE detector,has_finish_edge<Vis, E, G>, that checks whethervis.finish_edge(e, g)is a valid call. D#include <boost/tti/has_member_function.hpp><boost/type_traits/make_void.hpp>and<type_traits>.mpl::vector<E, const G&>that only existed to feed TTI's signature, so the file is now MPL-free as well.build.jam: dropped/boost/tti//boost_tti.CMakeLists.txt: droppedBoost::tti.All changes in
boost::detail, detection is identical forvoid finish_edge(Edge, const Graph&)visitors, and the check now works uniformly on C++14 compilers.Motivation
It's not worth pulling a Boost dependency anymore now that the sfinae + detector idiom are available in C++14.
Testing
Checklist
b2in thetest/directory).