chore(tsconfig): es2024 target/lib, require @types/node#54
Draft
natemoo-re wants to merge 1 commit into
Draft
Conversation
types:[node] turns a wall of TS2591 ambient-type errors into one actionable TS2688 when @types/node is missing. es2024 lib covers the modern APIs (toSorted, Promise.withResolvers) our lint rules push.
🦋 Changeset detectedLatest commit: 8c5c0f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Session logs showed ambient-type failures dominating real type errors across bombshell-dev projects: TS2591 (Cannot find name
process/Buffer) ×104, TS2304 ×114, TS2584 ×28 — every fresh package hit a wall of these because the shared tsconfig neither guaranteed@types/nodenor covered modern lib APIs.target/lib: es2022 → es2024, soArray.prototype.toSorted,Promise.withResolvers, etc. type-check without shims (our ownunicorn/no-array-sortrule pushestoSorted)"types": ["node"]: packages must now install@types/node. Missing it previously surfaced as dozens of TS2591s; now it's a single actionableCannot find type definition file for 'node'(TS2688). Remedy:pnpm add -D @types/node.Validation
@types/node: exactly one clear TS2688toSorted/Promise.withResolverstype-check under the new libIncludes changeset (minor).