chore: migration to @bomb.sh/tools - #604
Open
mixto wants to merge 7 commits into
Open
Conversation
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
commit: |
mixto
marked this pull request as ready for review
September 13, 2026 18:03
43081j
reviewed
Sep 14, 2026
| "types": "tsc --noEmit", | ||
| "deps": "pnpm exec knip --production", | ||
| "test": "pnpm --color -r run test", | ||
| "deps": "pnpm dlx knip --production", |
Collaborator
There was a problem hiding this comment.
bsh lint already runs knip afaiu. double check but we may be able to remove this script entirely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migration to the organisation’s tooling using
@bomb.sh/tools. This pull request updates the repository in relation to this #506 other one, which is very out of date.I have used the tsconfig.json configuration from the tools repository. I have left the compiler options that were not defined in the tools configuration.
The
depsscript usesknipto check dependencies. Thebsh lintcommand in the tools already usesknipwhen run. As the script is also used in workflows, it should be left as it is. I usepnpm dlxto call theknipbinary directly.