chore(deps): update deps in core and prompts packages#512
chore(deps): update deps in core and prompts packages#512
Conversation
|
commit: |
43081j
left a comment
There was a problem hiding this comment.
it builds! fair enough 😂
it is probably worth manually trying it out a bit too. do some weird stuff like a box with a lot of colour codes in it, or a box with a link in it is a good one
Should I try adding some tests with snapshots? |
|
I've just tested and the following fails on the main branch, I will test on this branch now const longUrl = 'https://example.com/very/long/path/that/exceeds/typical/terminal/width';
const link = `\x1b]8;;${longUrl}\x1b\\click\x1b]8;;\x1b\\`;
prompts.box(`Link: ${link}`, 'Long URL', { input, output, width: 'auto' });Tested, it passes on this branch, see gameroman@71efa67 |
|
we don't need new tests for it, i just want us to manually try out a few different cases to be sure its all still fine. sounds like it is 👍 |
No description provided.