Skip to content

chore(deps): update deps in core and prompts packages#512

Open
dreyfus92 wants to merge 1 commit intomainfrom
update/deps-001
Open

chore(deps): update deps in core and prompts packages#512
dreyfus92 wants to merge 1 commit intomainfrom
update/deps-001

Conversation

@dreyfus92
Copy link
Copy Markdown
Member

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 15, 2026

⚠️ No Changeset found

Latest commit: fdaba33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 15, 2026

commit: fdaba33

Copy link
Copy Markdown
Collaborator

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it builds! fair enough 😂

it is probably worth manually trying it out a bit too. do some weird stuff like a box with a lot of colour codes in it, or a box with a link in it is a good one

@gameroman
Copy link
Copy Markdown

it is probably worth manually trying it out a bit too. do some weird stuff like a box with a lot of colour codes in it, or a box with a link in it is a good one

Should I try adding some tests with snapshots?

@gameroman
Copy link
Copy Markdown

gameroman commented Apr 15, 2026

I've just tested and the following fails on the main branch, I will test on this branch now

const longUrl = 'https://example.com/very/long/path/that/exceeds/typical/terminal/width';
const link = `\x1b]8;;${longUrl}\x1b\\click\x1b]8;;\x1b\\`;
prompts.box(`Link: ${link}`, 'Long URL', { input, output, width: 'auto' });

Tested, it passes on this branch, see gameroman@71efa67

@43081j
Copy link
Copy Markdown
Collaborator

43081j commented Apr 16, 2026

we don't need new tests for it, i just want us to manually try out a few different cases to be sure its all still fine.

sounds like it is 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants