Skip to content

fix: route StdClock through crate::sys::time to prevent wasm panics#5398

Open
mansiverma897993 wants to merge 1 commit into
boa-dev:mainfrom
mansiverma897993:fix-5397
Open

fix: route StdClock through crate::sys::time to prevent wasm panics#5398
mansiverma897993 wants to merge 1 commit into
boa-dev:mainfrom
mansiverma897993:fix-5397

Conversation

@mansiverma897993

Copy link
Copy Markdown

This Pull Request fixes/closes #5397.

It changes the following:

  • Routes StdClock through crate::sys::time to prevent wasm panics.

@mansiverma897993 mansiverma897993 requested a review from a team as a code owner June 16, 2026 17:34
@github-actions github-actions Bot added the Waiting On Review Waiting on reviews from the maintainers label Jun 16, 2026
@github-actions github-actions Bot added this to the v1.0.0 milestone Jun 16, 2026
@github-actions

Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 53,125 53,125 0
Passed 51,072 51,072 0
Ignored 1,482 1,482 0
Failed 571 571 0
Panics 0 0 0
Conformance 96.14% 96.14% 0.00%

Tested main commit: 1af45b21c78187d145ced49502d7ab6415c8ce04
Tested PR commit: 25121a23b4eb0f61b43f42021674e6c4db859892
Compare commits: 1af45b2...25121a2

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.10%. Comparing base (6ddc2b4) to head (25121a2).
⚠️ Report is 979 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5398       +/-   ##
===========================================
+ Coverage   47.24%   60.10%   +12.86%     
===========================================
  Files         476      566       +90     
  Lines       46892    63033    +16141     
===========================================
+ Hits        22154    37886    +15732     
- Misses      24738    25147      +409     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OBWANDO OBWANDO left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much safer path and should resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StdClock (default Context clock) uses std::time directly, bypassing sys::time — Date panics on wasm32-unknown-unknown even with the js feature

2 participants