fix: deep clone scope in FunctionEnvironment to prevent variable leak…#5339
Draft
yush-1018 wants to merge 3 commits intoboa-dev:mainfrom
Draft
fix: deep clone scope in FunctionEnvironment to prevent variable leak…#5339yush-1018 wants to merge 3 commits intoboa-dev:mainfrom
yush-1018 wants to merge 3 commits intoboa-dev:mainfrom
Conversation
…age across eval invocations (boa-dev#5332) When eval('var x = ...') is called inside a function, Boa mutates the compile-time Scope (shared via Rc) to register the new binding. Because the same Scope was reused across invocations, the binding leaked into subsequent calls. Fix: add Scope::deep_clone() that creates a fresh copy of the bindings Vec, and use it in FunctionEnvironment::new() so each invocation gets its own isolated scope. Closes boa-dev#5332
Test262 conformance changes
Fixed tests (21):New panics (1):Tested main commit: |
…ch guard (mutation not allowed in guards)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5332
What's the bug?
When you call
eval('var x = 1')inside a function, the variablexwassticking around in the next call to that same function — even though it shouldn't.