Skip to content

core: frontend: vehiclesetup: PwmSetup: Lighten vehicle background - #4157

Open
patrickelectric wants to merge 1 commit into
bluerobotics:masterfrom
patrickelectric:lighten-pwm-vehicle
Open

core: frontend: vehiclesetup: PwmSetup: Lighten vehicle background#4157
patrickelectric wants to merge 1 commit into
bluerobotics:masterfrom
patrickelectric:lighten-pwm-vehicle

Conversation

@patrickelectric

Copy link
Copy Markdown
Member

The vehicle is almost invisible on the pwm outputs tab in dark mode.

Fix #1674

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@github-actions

Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: LGTM :shipit:

Adds color="grey lighten-3" to the v-card wrapping the vehicle-viewer in core/frontend/src/components/vehiclesetup/PwmSetup.vue so the vehicle model is visible in dark mode. Fixes #1674. Uses a Vuetify color helper that is already applied in similar contexts elsewhere in the codebase (e.g. RecordsView.vue, PullProgress.vue, several compass calibrator dialogs).

No further comments, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vehicle (on pwm outputs tab) very hard to see in dark mode

1 participant