Add virtual destructor to rmqt::VHostInfo - #88
Merged
Conversation
`rmqt::VHostInfo` declares virtual member functions, but didn't have a virtual destructor. Declare the destructor virtual to ensure correct destruction.
flamble
force-pushed
the
vhostinfo-virt-destructor
branch
from
July 29, 2026 13:24
4bd0fd7 to
1a464b6
Compare
willhoy
approved these changes
Jul 29, 2026
flamble
marked this pull request as ready for review
July 29, 2026 13:43
flamble
enabled auto-merge (squash)
July 29, 2026 13:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem statement
rmqt::VHostInfodeclares virtual member functions, but didn't have a virtual destructor.Proposed changes
Declare the destructor virtual to ensure correct destruction.