Skip to content

Add product_chain and version_chain to AMQP client properties#81

Merged
Rahmeen14 merged 2 commits intobloomberg:mainfrom
Rahmeen14:fix/add-product-version-chains
Apr 16, 2026
Merged

Add product_chain and version_chain to AMQP client properties#81
Rahmeen14 merged 2 commits intobloomberg:mainfrom
Rahmeen14:fix/add-product-version-chains

Conversation

@Rahmeen14
Copy link
Copy Markdown
Contributor

@Rahmeen14 Rahmeen14 commented Apr 13, 2026

Problem statement

Allow wrapper libraries to override product and version client properties, and add two new pipe-delimited fields (product_chain and version_chain) for full library stack traceability in the RabbitMQ management UI.
Previously, generateClientProperties() always overwrote product and version with rmqcpp's values, making it impossible for wrapper libraries to identify themselves.

Proposed changes

  • Extract setChainProperties() helper from generateClientProperties()
  • If the caller provides product_chain/version_chain, append rmqcpp to the chain
  • If the caller only provides product/version (no chains), build the chain from both
  • If nothing is provided, initialize the chain with rmqcpp's own identity
  • All .thebsl::string() calls guarded with .isbsl::string() type checks

Remaining work

  • Unit Tests
  • Integration Tests
  • Documentation

@Rahmeen14 Rahmeen14 force-pushed the fix/add-product-version-chains branch from 5d3dc93 to 05c8704 Compare April 13, 2026 11:50
@Rahmeen14 Rahmeen14 marked this pull request as ready for review April 13, 2026 11:51
@Rahmeen14 Rahmeen14 force-pushed the fix/add-product-version-chains branch 5 times, most recently from 9c0e8aa to 3412386 Compare April 14, 2026 15:29
@Rahmeen14 Rahmeen14 enabled auto-merge (squash) April 16, 2026 11:00
@Rahmeen14 Rahmeen14 force-pushed the fix/add-product-version-chains branch from f64c346 to 9be2bd8 Compare April 16, 2026 11:57
@Rahmeen14 Rahmeen14 force-pushed the fix/add-product-version-chains branch from 9be2bd8 to 996a8d9 Compare April 16, 2026 12:06
@Rahmeen14 Rahmeen14 merged commit 4f9ac91 into bloomberg:main Apr 16, 2026
4 checks passed
@Rahmeen14 Rahmeen14 deleted the fix/add-product-version-chains branch April 16, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants