Skip to content

updated ubuntu version in dockerfile#297

Merged
godlygeek merged 1 commit into
bloomberg:mainfrom
nitinryali:fix/ubuntu_version_bump
May 21, 2026
Merged

updated ubuntu version in dockerfile#297
godlygeek merged 1 commit into
bloomberg:mainfrom
nitinryali:fix/ubuntu_version_bump

Conversation

@nitinryali
Copy link
Copy Markdown
Contributor

*Issue number of the reported bug or feature request: #295

Describe your changes
Updated ubuntu version in dockerfile for both stages

Testing performed
Build the image from the docker file

Additional context

@nitinryali
Copy link
Copy Markdown
Contributor Author

Screenshot 2026-05-19 at 12 35 49 AM

@sarahmonod sarahmonod linked an issue May 18, 2026 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.19%. Comparing base (debc9e8) to head (fd24d20).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
- Coverage   79.19%   79.19%   -0.01%     
==========================================
  Files          51       51              
  Lines        5542     5561      +19     
  Branches      577      583       +6     
==========================================
+ Hits         4389     4404      +15     
- Misses       1153     1157       +4     
Flag Coverage Δ
cpp 79.19% <ø> (-0.01%) ⬇️
python 79.19% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@godlygeek godlygeek force-pushed the fix/ubuntu_version_bump branch 2 times, most recently from 3d4ea7e to a4b1f4f Compare May 21, 2026 06:36
Prevent the test suite from reaching out to the Ubuntu debuginfod
server when tests are run in the devcontainer, as otherwise one of the
tests hangs while trying to symbolize due to an ongoing DDOS attack
targeting Ubuntu. Since we don't need the debuginfod server, there's no
need to add any load to it.

Co-authored-by: Matt Wozniski <godlygeek@gmail.com>
@godlygeek godlygeek force-pushed the fix/ubuntu_version_bump branch from a4b1f4f to fd24d20 Compare May 21, 2026 07:10
Copy link
Copy Markdown
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out in GitHub Codespaces, and the test suite hung. It was unable to download from the Ubuntu debuginfod server, which is configured by default. It seems like that's because Ubuntu is currently under a DDOS attack that's rendering the debuginfod server unusable. Since we don't need it anyway, I've updated the container to prevent debuginfod from being used by default.

Other than that, this looks good to me. Thanks for the contribution, @nitinryali!

@godlygeek godlygeek enabled auto-merge (rebase) May 21, 2026 07:21
@godlygeek godlygeek merged commit a2d9b6b into bloomberg:main May 21, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update our Dockerfile to the latest Ubuntu version

3 participants