feat: support external material locators - #247
Merged
Merged
Conversation
Allow annotated material references and approved connector schemes while preserving notes through pull, review, and export. Keep external access host-managed and report archive portability accurately. Co-authored-by: Goose <opensource@block.xyz> Ai-assisted: true
chailandau
force-pushed
the
chai/external-materials
branch
from
July 29, 2026 16:55
196526a to
8ea72ae
Compare
…me docs Address review gaps on the external material locator work: - Export audit names the provider (mcp/figma/github) instead of a flat "connection-dependent" label, at the markdown layer only; the export JSON access contract is unchanged. Adds externalLocatorScheme() as the single source for scheme extraction. - Add end-to-end coverage for a single node carrying a bare local path, a bare https: URL, and an annotated mcp: declaration together through pull, and widen export --strict to span mcp:/figma:/github:. - Collapse the verbatim scheme list from six doc surfaces to one canonical enumeration in references/schema.md; other docs defer to it. The code allowlist remains the source of truth. Co-authored-by: Chai Landau <chai@block.xyz> Signed-off-by: Chai Landau <chai@block.xyz>
The changeset described the two original public helpers but not externalLocatorScheme(), the third /core export added while naming the export audit provider. Extend the entry to cover both. Co-authored-by: Chai Landau <chai@block.xyz> Signed-off-by: Chai Landau <chai@block.xyz>
chailandau
marked this pull request as ready for review
July 29, 2026 20:39
chailandau
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Ghost material guidance needs to point at authenticated or provider-backed sources without fetching them itself or collapsing retrieval context into prose.
What
{ locator, note }declarationshttps:,mcp:,figma:, andgithub:external locators while rejecting unsafe or targetless schemesRisk Assessment
Medium-low — this widens public material types and adds optional JSON fields, but retains bare strings and legacy
tier: "url"values. Ghost remains offline and external access stays with the host agent.References
pnpm test: 197 passed, 1 skippedpnpm check: passed, including packed-package, release-tarball, terminology, and Vessel Light closure checksjust ci: passedtest,ci, and Block-org checks: passedGenerated with Goose