Drop always-id match_field from ListPathSegment runtime metadata#1241
Open
ellisandrews-toast wants to merge 1 commit into
Open
Drop always-id match_field from ListPathSegment runtime metadata#1241ellisandrews-toast wants to merge 1 commit into
ellisandrews-toast wants to merge 1 commit into
Conversation
myronmarston
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
match_fieldattribute fromListPathSegmentin the runtime metadata, and switches the list-vs-object segment discriminator inSourcedFromNestedPathSegment.from_hashfrommatch_fieldtosource_field.Why
match_fieldwas always"id"— ElasticGraph relationships join onidvia foreign keys, so the value carried no information. Serializing a constant into runtime metadata adds noise without value, and keeping it would have meant emittingmatch_field: "id"intoruntime_metadata.yamlonce nested sourced paths are actually populated.This mirrors the equivalent cleanup already applied to the schema-definition
PathSegmentin #1238. The match is now implicit: list elements are matched onidagainst the value atsource_field. If non-idprimary keys are supported in the future, the field can be reintroduced then.Scope / risk
Low.
ListPathSegmentis not yet constructed by any production code — only by the round-trip serialization unit test — so there is no schema-artifact churn and nothing downstream consumes the removed field. Specs and type checks pass.