fix: Replace scheduler channel with sync.Cond to prevent deadlock#261
Merged
alecthomas merged 1 commit intomainfrom Apr 15, 2026
Merged
fix: Replace scheduler channel with sync.Cond to prevent deadlock#261alecthomas merged 1 commit intomainfrom
alecthomas merged 1 commit intomainfrom
Conversation
alecthomas
force-pushed
the
aat/fix-scheduler-deadlock
branch
from
6fb0e18 to
9141807
Compare
stuartwdouglas
approved these changes
Apr 15, 2026
Contributor
stuartwdouglas
left a comment
stuartwdouglas
left a comment
There was a problem hiding this comment.
LGTM, but it looks like the tests have issues with the race detector.
alecthomas
force-pushed
the
aat/fix-scheduler-deadlock
branch
from
9141807 to
4e16550
Compare
Workers and Submit() callers could deadlock when the workAvailable channel buffer (1024) filled up. All workers would block on the deferred channel send in runJob, preventing any reader from draining the channel. sync.Cond.Signal() never blocks, eliminating the issue. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alecthomas
force-pushed
the
aat/fix-scheduler-deadlock
branch
from
4e16550 to
a2f3ed0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workers and Submit() callers could deadlock when the workAvailable
channel buffer (1024) filled up. All workers would block on the
deferred channel send in runJob, preventing any reader from draining
the channel. sync.Cond.Signal() never blocks, eliminating the issue.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com