Skip to content

feat(acp): add owner broadcast routing - #4644

Open
koltyj wants to merge 1 commit into
block:mainfrom
koltyj:cody/owner-broadcast-routing
Open

feat(acp): add owner broadcast routing#4644
koltyj wants to merge 1 commit into
block:mainfrom
koltyj:cody/owner-broadcast-routing

Conversation

@koltyj

@koltyj koltyj commented Aug 4, 2026

Copy link
Copy Markdown

Summary

  • add an owner-broadcast ACP subscription mode
  • broadcast an owner's untagged messages to every owned agent
  • keep explicit agent mentions exclusive to the tagged agents
  • include stream messages, forum posts, forum comments, approvals, and reminders by default
  • document the mode and its environment setting

Validation

  • bin/just ci
  • ACP routing tests cover untagged owner messages, targeted agents in both tag orders, human recipients, lookup failures, non-owner messages, and forum kinds

Originating Buzz channel: 7a80f7af-3bec-4e17-a4ee-9f006a6eeac8

Co-authored-by: Kolton Jacobs <krjhawks@gmail.com>
Signed-off-by: Kolton Jacobs <krjhawks@gmail.com>
@koltyj
koltyj requested a review from a team as a code owner August 4, 2026 01:20

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 92df2c6cfe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 372 to +374
let event = match events.first() {
Some(e) => e,
None => return false,
None => return Some(false),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Treat a missing agent profile as unresolved

When an owner explicitly targets a newly created agent whose kind:0 profile has not propagated yet, a successful empty query is not proof that the pubkey belongs to a human. Returning Some(false) here causes owner_broadcast_allows to continue broad delivery, so every older agent can execute a message intended exclusively for the new agent; the negative result is also cached for the process lifetime. Treat an empty or not-yet-attested profile as unresolved (None) or otherwise revalidate it before broadening delivery.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant