Skip to content

test(acp): harden permission mode regression coverage - #4626

Open
maxitoon wants to merge 2 commits into
block:mainfrom
maxitoon:acp-permission-mode-regression-tests
Open

test(acp): harden permission mode regression coverage#4626
maxitoon wants to merge 2 commits into
block:mainfrom
maxitoon:acp-permission-mode-regression-tests

Conversation

@maxitoon

@maxitoon maxitoon commented Aug 3, 2026

Copy link
Copy Markdown

Summary

  • Add a regression test for the bounded ACP permission-mode request timeout.
  • Add positive end-to-end coverage proving an advertised non-default mode emits session/set_config_option with the expected mode value.
  • Add a negative end-to-end gate proving an unadvertised mode does not emit that request.

This is intentionally complementary to #4280, which covers the production-side stable configOptions advertisement fix. The duplicate advertisement unit cases were left out of this PR.

Related issues

Verification

  • cargo fmt --all -- --check
  • cargo test -p buzz-acp --all-targets — 671 unit tests and 9 integration tests passed
  • Permission-mode tests passed across five serial repetitions before the final overlap cleanup

The subprocess tests are Unix-gated because they exercise the existing Bash/read -t ACP harness path.

Maxime Tolos added 2 commits August 3, 2026 23:51
Signed-off-by: Maxime Tolos <max@maximetolos.com>
Signed-off-by: Maxime Tolos <max@maximetolos.com>
@maxitoon
maxitoon requested a review from a team as a code owner August 3, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant