feat(agents): harness-agnostic effort write-side + spawn legacy bridge

[wpfleger96]

Summary

Genericizes the agent effort write-side so non-Buzz runtimes (starting with Goose) participate in the same canonical effort contract as buzz-agent, with a spawn bridge that translates the canonical key to whatever the target harness expects at launch time.

Three commits on top of main (631b05c88).

---

Phase 1 — B-collapse + ACP identity + alias normalization

desktop/src-tauri/src/managed_agents/config_bridge/

• B-collapse for same-value live effort. Previously a live thought_level option whose raw value equalled the global default was reported as a live override instead of collapsing to GlobalDefault. Fixed: compare via normalized values after applying effort_norm.
• thought_level ACP identity. When both thought_level and thinking_effort ACP categories are present, thought_level wins. The winning entry's config_id is captured and forwarded to write_via; it is always entry-supplied, never hardcoded.
• ACP effort normalization. The selected ACP option's value is normalized through effort_norm before candidate-list construction and B comparison. An invalid ACP value (e.g. minimal for Goose) is omitted as a value candidate so a lower tier wins; write_via stays AcpSetConfigOption with the entry-supplied config_id because the route targets the option, not its current value.
• Alias normalization (TS). normalizeEffortValue in buzzAgentConfig.ts applies the same Goose alias table as the Rust effort_norm: none/disabled→off, med→medium, xhigh→max, case-insensitive. Canonical values pass through; unrecognised values return null (buzz-agent path: acceptedValues=null passes through raw).

---

Phase 2 — Canonical effort contract + native-key persistence + mutation contract

desktop/src/features/agents/

Single read policy. resolveEffortFromEnv(envVars, nativeKey, legacyKey, acceptedValues) in agentConfigCore.ts is the authoritative read path for all effort surfaces. It normalizes, applies native-first / valid-legacy-fallback, and returns { value, legacyConsumed }. deriveAgentConfigFieldModel, HarnessNativeEffortFields, and both editors' legacyEffortConsumed memos all call it.

Descriptor. deriveAgentConfigFieldModel emits an effort field with:

• optionSource: "harnessNative" for runtimes with a static acceptedEffortValues vocabulary (Goose); "buzzAgentCatalog" for buzz-agent; "legacyProviderModelCatalog" otherwise.
• acceptedEffortValues from runtime metadata — never the seven-value buzz-agent list.
• Legacy fallback (legacyKey = BUZZ_AGENT_THINKING_EFFORT) at record/persona scope only; omitted at global/onboarding (Delta 5: that key is buzz-agent's own native key there).

UI surfaces. AgentConfigFields (global/onboarding), PersonaAdvancedFields (persona/definition), and EditAgentAdvancedFields (record/instance) all branch on optionSource === "harnessNative". For harness-native runtimes they render HarnessNativeEffortFields with runtime metadata; EffortSelectField receives canonical choices from acceptedEffortValues, not the Buzz catalog.

HarnessNativeEffortFields. Accepts a legacyEnvKey prop (passed only by the definition/instance editors, not global). Reads via resolveEffortFromEnv. Save = canonical native write + atomic legacy delete at record/persona scope; native-key-only at global scope (preserves coexisting foreign native keys — Delta 5).

applyHarnessNativeEffortChange. Exported production mutation helper called by both the component and AgentConfigFields's onChange. Encodes the scope-split policy: legacyKey = BUZZ_AGENT_THINKING_EFFORT at record/persona; legacyKey = null at global. Tests import and exercise it directly.

Model-coupled mutation guard. Heal-on-mount, orphan-clear, and useEffortAutoClear in AgentConfigFields skip the native effort key when isHarnessNativeEffort. Goose effort is model-independent — its vocabulary is static; the reader's skip-as-absent contract handles invalid values non-destructively. The useEffortAutoClear hook receives "" as currentEffort for harness-native runtimes, making it a no-op. BUZZ_AGENT_THINKING_EFFORT deletions on those paths also remain guarded behind !isHarnessNativeEffort.

Inherit-transition strip. resolveInheritedRuntimeSubmission accepts excludePersonaEnvKeys to strip effort keys from the persona merge layer on a pinned→inherit transition. AgentInstanceEditDialog passes [thinkingEnvVar, ...ALL_KNOWN_EFFORT_KEYS] when the runtime has thinkingEnvVar. Gated on thinkingEnvVar (not Goose-specific) — applies to all runtimes with a native effort key, including buzz-agent; spawn still inherits persona effort at the persona tier.

Legacy row visibility. legacyConsumedKey controls advanced-row suppression. The legacy row is hidden only when the key was validly consumed; invalid or unrecognised legacy values remain visible as advanced env rows.

---

Phase 3 — Shared alias resolver + spawn effort bridge + deploy test

desktop/src-tauri/

effort_tier_alias. runtime_metadata.rs now exposes effort_tier_alias(value, accepted_values, global_tier) — the shared normalizer used by build_thinking_field and apply_effort_bridge. Applies the Goose alias table; returns None for unrecognised values (skip-as-absent).

apply_effort_bridge. managed_agents/spawn/ bridges canonical effort onto the spawn payload:

• Strips all known foreign effort keys from the env before inserting the resolved winner.
• For local agents: writes to env_vars on the AgentCommandConfig.
• For deploy/cloud agents: writes to launch_config.launch.env (the per-launch env overlay); top-level env_vars is left unbridged, preserving the stored record.
• Resolves the canonical winner from all tiers (record native → record legacy → persona native → persona legacy → global native), normalized through effort_tier_alias.

Deploy integration test. agent_deploy_effort_bridge_test.rs asserts that apply_effort_bridge writes to launch.env, not env_vars, and that foreign keys are stripped from both.

---

Test coverage

• Rust: ACP B-collapse, thought_level priority, ACP alias/case/invalid normalization, alias resolver tiers, bridge descriptor hygiene, deploy parity boundary.
• TS: resolveEffortFromEnv read policy (native-first, legacy fallback, tier boundary, null-legacyKey); applyHarnessNativeEffortChange scope-split mutation; deriveAgentConfigFieldModel at global/definition/instance scope; HarnessNativeEffortFields legacy migration; excludePersonaEnvKeys inherit-transition strip; isHarnessNativeEffort guard (xhigh survives model-heal; minimal survives; buzz-agent auto-clear unchanged); inherited-defaults normalization; global coexisting native-pair preservation.