fix(acp): isolate Claude sessions from host credentials - #4611
Open
jmecom wants to merge 2 commits into
Open
Conversation
Co-authored-by: Jordan Mecom <jm@squareup.com> Signed-off-by: Jordan Mecom <jm@squareup.com>
Co-authored-by: Jordan Mecom <jm@squareup.com> Signed-off-by: Jordan Mecom <jm@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change launches Claude ACP adapters with an allowlisted parent environment and disposable home, config, cache, and application-data directories. It also sends
settingSources: []so Claude does not automatically load the operator's user, project, or local settings.The rebase preserves current main's Claude system-prompt transport and session-title metadata alongside the isolation options. This prevents automatic credential and configuration inheritance; it is not an OS sandbox and does not block deliberate absolute-path or keychain access by an otherwise-authorized tool.
Testing
env -u BUZZ_ACP_LAZY_POOL bin/cargo test -p buzz-acpat7de5f4a: 673 library tests and 9 integration tests passedbin/cargo fmt --all -- --checkat7de5f4agit diff --check origin/main...codex/security-claude-env-isolationOriginating Buzz thread:
buzz://message?channel=3928fe05-df61-4b5d-b9c7-d623b9b10ea1&id=3c6c02312f763fbe0d2bfc33a6c1a362f91d0354f3d18b039cf7a0558c1439d1