test: remove dead symbols in onboarding e2e spec#1046
Draft
tellaho wants to merge 1 commit into
Draft
Conversation
biome noUnusedVariables flagged two unused symbols in onboarding.spec.ts (const FIRST_RUN_KENNY, function getMockProfile). Under pull_request builds biome escalates these to errors, failing Desktop Core (biome check .). Removing them clears the gate. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: fix
User Impact: None user-facing — this is CI hygiene that unblocks PRs from merging.
Problem:
maincarries two unused symbols indesktop/tests/e2e/onboarding.spec.ts—const FIRST_RUN_KENNYandfunction getMockProfile. biome'snoUnusedVariablesflags both. Because biome hasvcs.enabled: true, push builds (main) see the file as unchanged and soften the finding to a warning, so main stays green. But pull_request builds escalate the same finding to an error, failing theDesktop Core(biome check .) gate. Net result: main is quietly red under PR rules, blocking PR #1044.Solution: Remove the two dead symbols. Nothing else touched.
biome check .now passes under PR context.File changes
desktop/tests/e2e/onboarding.spec.ts
Removed the unused
FIRST_RUN_KENNYconstant and the unusedgetMockProfilehelper function. Both had zero references in the file or repo-wide. 25 deletions, no other changes.Reproduction Steps
pnpm checkfrom the repo root.biome check .passes clean for bothwebanddesktopworkspaces (666 desktop files checked, no errors).PR authored by Bart 🤖