fix(staged): prevent double review row when adopting already-running autoreview#638
Merged
fix(staged): prevent double review row when adopting already-running autoreview#638
Conversation
…autoreview Check session status before attempting resume in tryAdoptAutoReview. If the session is already running, register it on the frontend instead of calling resumeSession (which rejects already-running sessions). Move setReviewAuto after fallible operations so the review stays hidden if adoption fails, preventing the revealed-autoreview + new-session double row. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…lication Extract a private registerRunningSession() method that encapsulates the paired sessionRegistry.register + projectStateStore.addRunningSession calls. This pattern appeared in 4 places (3 in tryAdoptAutoReview, 1 in startBranchSessionWithPendingItem) and was flagged in code review as easy to get out of sync if either call changed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registerRunningSessionhelper to reduce duplication ofsessionRegistry.register+projectStateStore.addRunningSessioncallssetReviewAuto(reveal) until after all fallible operations succeed, preventing a review from being revealed in a broken stateTest plan
🤖 Generated with Claude Code