fix(staged): resolve hashtag badge showing raw IDs instead of titles#636
Merged
fix(staged): resolve hashtag badge showing raw IDs instead of titles#636
Conversation
hashtagItems were loaded once at mount via a separate API call and never refreshed, so references to items created after mount showed raw IDs instead of titles. Derive hashtagItems reactively from the timeline state that is already kept up-to-date, and render badges for pending session items that previously skipped titleHtml entirely. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove unused ProjectNote type import from BranchCard.svelte - Export projectNotesToHashtagItems from hashtagItems.ts and reuse it in BranchCard.svelte instead of duplicating the filter+map logic Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…lback The badge already renders with a "Review:" label prefix, so the fallback title only needs the short SHA — not "Review of <SHA>" which produced the redundant "Review: Review of abc1234". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace the inline filter+map logic in BranchCard.svelte with a call to the already-exported projectNotesToHashtagItems helper from hashtagItems.ts, completing the refactor stated in commit 1475783.
matt2e
force-pushed
the
id-showing-in-hashtag-badge
branch
from
6f4c17f to
4a8327d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildBranchHashtagItemsinto reactive timeline-derived items and once-loaded project note itemstimelineToHashtagItemsandprojectNotesToHashtagItemsfor direct use in BranchCardTest plan
🤖 Generated with Claude Code