Skip to content

MB-72082: fix a racy read in stats computation #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Thejas-bhat wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MB-72082: fix a racy read in stats computation #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d55831
fix racy read
Thejas-bhat Aug 21, 2026
32b5fb1
udpate error stats
Thejas-bhat Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions stats.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ type Stats struct {
TotNewDocsDropped uint64
TotNewVectorsProcessed uint64

TotPersistBeg uint64
TotPersistEnd uint64
TotPersistErrors uint64
TotPersistBeg uint64
TotPersistEnd uint64
TotPersistErr uint64

TotMergesBeg uint64
TotMergesEnd uint64
Expand All @@ -41,6 +41,7 @@ type Stats struct {

TotVecSectionMergesBegin uint64
TotVecSectionMergesEnd uint64
TotVecSectionMergeErr uint64
TotVecSectionMergeTime uint64
TotVecSectionVecsReconstructed uint64
TotVecSectionIVFIndexesCreated uint64
Expand Down Expand Up @@ -68,7 +69,7 @@ type Stats struct {
}

func (s *Stats) StatsMap() map[string]interface{} {
svet := reflect.TypeOf(*s)
svet := reflect.TypeOf(s).Elem()
n := svet.NumField()
m := make(map[string]interface{}, n)
base := unsafe.Pointer(s)
Expand Down
Loading