QA-2360: Add organization cipher seeder scenes for remaining item types - #8323
QA-2360: Add organization cipher seeder scenes for remaining item types#8323Corbet-BW wants to merge 1 commit into
Conversation
Adds Organization{SecureNote,Identity,Passport,DriversLicense,BankAccount}
CipherScene, mirroring the existing OrganizationCardCipherScene: each resolves
the org, builds the type's view DTO, seeds via the matching {Type}CipherSeeder
with the org key and UserId null, and persists to the requested collections.
Completes the org-owned cipher scenes (login + card already existed).
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed five new organization-owned cipher seeder scenes under Code Review DetailsNo findings met the confidence threshold for posting. The per-type duplication across these five scenes was considered and not flagged: the PR body records it as a deliberate direction to follow the card example, with a possible later consolidation into a parameterized |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8323 +/- ##
==========================================
- Coverage 63.89% 63.89% -0.01%
==========================================
Files 2471 2471
Lines 105959 105959
Branches 9603 9603
==========================================
- Hits 67701 67700 -1
- Misses 35916 35917 +1
Partials 2342 2342 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/QA-2360
📔 Objective
Adds the remaining organization-owned cipher seeder scenes so the seeder can create org ciphers of every item type (login + card already existed):
OrganizationSecureNoteCipherSceneOrganizationIdentityCipherSceneOrganizationPassportCipherSceneOrganizationDriversLicenseCipherSceneOrganizationBankAccountCipherSceneEach mirrors the existing
OrganizationCardCipherScene(#8294): resolve the org, build the type's view DTO, seed via the matching{Type}CipherSeederwith the org key andUserIdnull, and persist to the requested collections. Type-specific fields come from the correspondingUser{Type}CipherScene.Per direction from Ned/Andrew these are per-type scenes following the card example; a later refactor may consolidate them into a single parameterized
OrganizationItemTypeCipherScene.No new tests — cipher-seeder coverage already exists in
RustSdkCipherTests(per the #8294 review, which removed a redundant per-factory test).📸 Screenshots
N/A — seeder/back-end only, no UI.