Skip to content

[PM-42203] Add feature flag enable-basic-auth-response - #8248

Open
jprusik wants to merge 1 commit into
mainfrom
pm-42203
Open

[PM-42203] Add feature flag enable-basic-auth-response#8248
jprusik wants to merge 1 commit into
mainfrom
pm-42203

Conversation

@jprusik

@jprusik jprusik commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

PM-42203

📔 Objective

Add feature flag enable-basic-auth-response

See corresponding clients work at bitwarden/clients#22612

@jprusik jprusik self-assigned this Aug 24, 2026
@jprusik jprusik added feature-flag ai-review-vnext Request a Claude code review using the vNext workflow labels Aug 24, 2026
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds a single feature flag constant EnableBasicAuthResponse (enable-basic-auth-response) to the Autofill Team section of src/Core/Constants.cs. The constant name, string value, and placement all follow the conventions used by neighboring flags in the same section, and the flag is not yet referenced by server code — consistent with the corresponding clients-side work linked in the description. No security, correctness, or breaking-change concerns were identified.

@jprusik
jprusik requested review from a team and blackwood August 24, 2026 18:43
@jprusik

jprusik commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

Test failures exist and are from main

@jprusik
jprusik requested a review from bensbits91 August 24, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow feature-flag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant