[PM-40805] feat: Rename "Move to vault" to "Move"

[andrebispo5]

⚠️ Note

Stacked on #7196 (VFO-1 naming re-add)

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-40805

📔 Objective

Renames "Move to vault" to "Move" in the overflow menu item and the destination screen's app-bar title, per updated requirements on the VFO-1 epic (PM-40638 is now on hold; this text supersedes it). The confirm button already reads "Move" and needed no change.

Also updates the "Vault" field's selection dialog on the Move screen so its title reads "Filter items by vault" (per Figma), instead of reusing the field's own "Vault" label. BitwardenMultiSelectButton now accepts an optional dialogTitle param for this, defaulting to the existing label-reuse behavior for every other call site.

📸 Screenshots

Move in cipher options:

Move title and button:

Vault selection dialog ("Filter items by vault" title):

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.09%. Comparing base (6db4af6) to head (8af3d44).

Additional details and impacted files

@@                    Coverage Diff                     @@
##           readd-vfo1-naming-changes    #7200   +/-   ##
==========================================================
  Coverage                      86.09%   86.09%           
==========================================================
  Files                            887      887           
  Lines                          64750    64751    +1     
  Branches                        9674     9674           
==========================================================
+ Hits                           55746    55747    +1     
  Misses                          5538     5538           
  Partials                        3466     3466           

Flag	Coverage Δ
app-data	17.76% <0.00%> (-0.01%)	⬇️
app-ui-auth-tools	18.78% <0.00%> (-0.01%)	⬇️
app-ui-platform	16.55% <0.00%> (-0.01%)	⬇️
app-ui-vault	27.36% <100.00%> (+<0.01%)	⬆️
authenticator	6.10% <0.00%> (-0.02%)	⬇️
lib-core-network-bridge	4.01% <0.00%> (-0.01%)	⬇️
lib-data-ui	1.15% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the rename of "Move to vault" to "Move" across the cipher overflow menus, the move destination screen's app-bar title, and the associated tests. Also reviewed the new optional dialogTitle parameter on BitwardenMultiSelectButton used to give the Vault field's selection dialog a "Filter items by vault" title, plus the removal of the now-unused move_to_vault string. The change is well-scoped, backward compatible (the new param defaults to the existing label-reuse behavior), and the removed string has no remaining references. Test updates correctly disambiguate the now-duplicate "Move" text using hasClickAction().

Code Review Details

No findings. The string removal is complete, the new dialogTitle parameter is optional and threaded correctly through both BitwardenMultiSelectButton overloads with KDoc updated, and the move_to_vault_desc string (distinct from the removed move_to_vault) is correctly retained.

[Copilot]

Pull request overview

Renames the “Move to vault” UI label to “Move” in the vault item overflow menu and the Move destination screen title, and updates the Move screen’s vault picker dialog title to match the latest VFO-1 wording requirements.

Changes:

• Replace “Move to vault” with “Move” in overflow menu items and Move screen app bar title.
• Add an optional dialogTitle parameter to BitwardenMultiSelectButton and use it to show “Filter items by vault” on the Move screen’s vault selection dialog.
• Update Compose UI tests to match the new “Move” label.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
ui/src/main/res/values/strings.xml	Removes the move_to_vault string (UI now uses move).
ui/src/main/kotlin/com/bitwarden/ui/platform/components/dropdown/BitwardenMultiSelectButton.kt	Adds optional dialogTitle and uses it for the selection dialog title.
app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/movetoorganization/VaultMoveToOrganizationScreenTest.kt	Updates tests for “Move” label; needs robustness adjustments around disabled button semantics.
app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt	Updates overflow-menu assertions from “Move to vault” to “Move”.
app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt	Updates overflow-menu assertions from “Move to vault” to “Move”.
app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/movetoorganization/VaultMoveToOrganizationViewModel.kt	Switches app bar title text from move_to_vault to move.
app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/movetoorganization/VaultMoveToOrganizationContent.kt	Sets the vault picker dialog title to filter_by_vault.
app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreen.kt	Updates overflow menu item label to move.
app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt	Updates overflow menu item label to move.

Comments suppressed due to low confidence (2)

app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/movetoorganization/VaultMoveToOrganizationScreenTest.kt:15

• The updated matchers use hasTestTag(...) / hasContentDescription(...) / onNodeWithTag(...), but the corresponding imports aren't present yet. Add the missing test imports so the file compiles.

import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.assertIsNotDisplayed
import androidx.compose.ui.test.assertIsOff
import androidx.compose.ui.test.assertIsOn
import androidx.compose.ui.test.filterToOne
import androidx.compose.ui.test.hasAnyAncestor
import androidx.compose.ui.test.hasClickAction
import androidx.compose.ui.test.isDialog
import androidx.compose.ui.test.onAllNodesWithText
import androidx.compose.ui.test.onLast
import androidx.compose.ui.test.onNodeWithContentDescription
import androidx.compose.ui.test.onNodeWithText
import androidx.compose.ui.test.performClick

app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/movetoorganization/VaultMoveToOrganizationScreenTest.kt:93

• This test also relies on hasClickAction() while the app bar button is disabled in ViewState.Loading. Using the MoveButton testTag and asserting the button’s contentDescription avoids depending on click semantics (which can change when disabled).

        composeTestRule
            .onNodeWithText(text = "Save")
            .assertIsNotDisplayed()
        composeTestRule
            .onAllNodesWithText(text = "Move")
            .filterToOne(hasClickAction())
            .assertIsDisplayed()

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.