PM-40154: feat: Migrate user data to KeystoreEncryptedSharedPreferences - #7158
PM-40154: feat: Migrate user data to KeystoreEncryptedSharedPreferences#7158david-livefront wants to merge 1 commit into
Conversation
d7c24bb to
aa9e67c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7158 +/- ##
==========================================
- Coverage 86.36% 85.92% -0.44%
==========================================
Files 916 1040 +124
Lines 65833 67672 +1839
Branches 9718 9814 +96
==========================================
+ Hits 56854 58146 +1292
- Misses 5509 6016 +507
- Partials 3470 3510 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
18d2899 to
0405c99
Compare
0405c99 to
ffcb25d
Compare
ffcb25d to
bafe9cf
Compare
quexten
left a comment
There was a problem hiding this comment.
If we had a tech breakdown beforehand, I'd recommend implementing this in the SDK based on our modern encryption primitives instead. Given the stage, I'll comment the minimum to make this reasonably secure. I recommend dropping the separate MAC key, and switching from CBC to GCM. Currently, the API is very easy to misuse, and you generally do not want to expose separate authentication and encryption (without authentication) APIs.
e7abca5 to
4eb424e
Compare
1249224 to
2fc6a32
Compare
ff16d4c to
2be57f3
Compare
2be57f3 to
5ae0b10
Compare
5ae0b10 to
1817972
Compare
🎟️ Tracking
PM-40154
📔 Objective
This PR creates a new
KeystoreEncryptedSharedPreferencesthat utilizes theAndroidKeystoreto encrypt the data stored.Notable changes:
EncryptedSharedPreferenceswhich is deprecated and is not FIPS compliant.Strings(this is the only type we need at the moment).